Support for volumes as issues

[Sakujakira]

Description of the bug
GetComics Download download Link extraction fails. Manually looking at the site, there is clearly a link.

To Reproduce
Add Bloodstain (2016)
Start manuall search for Issue Number 2
i get 2 search results, only one is correct
Try to download the correct one, relase gets blacklisted.

Expected behaviour
Downloading Issue 2
Link

Screenshots
None

Version info
Kapowarr version | v1.0.0-beta-13.8.16.final.06
/app/db/Kapowarr.db
/app
Browser: Brave v1.51.118 (May 17, 2023)
OS: Synology DSM 7.1. but in Docker

Additional context

This is only an example an can be reproduced with several other series

[2023-05-25 10:26:09][waitress-0][INFO] Starting manual search: Blood Stain (2016) #2
[2023-05-25 10:26:09][waitress-0][DEBUG] Starting new HTTPS connection (1): getcomics.org:443
[2023-05-25 10:26:10][waitress-0][DEBUG] https://getcomics.org:443 "GET /?s=Blood+Stain+%232+%282016%29 HTTP/1.1" 200 None
[2023-05-25 10:26:10][waitress-0][DEBUG] Using selector: EpollSelector
[2023-05-25 10:26:10][waitress-0][DEBUG] Starting new HTTPS connection (1): getcomics.org:443
[2023-05-25 10:26:10][waitress-0][DEBUG] https://getcomics.org:443 "GET /?s=Blood+Stain+Vol.+1+%232 HTTP/1.1" 200 None
[2023-05-25 10:26:10][waitress-0][DEBUG] Using selector: EpollSelector
[2023-05-25 10:26:10][waitress-0][DEBUG] Starting new HTTPS connection (1): getcomics.org:443
[2023-05-25 10:26:10][waitress-0][DEBUG] https://getcomics.org:443 "GET /?s=Blood+Stain+%232 HTTP/1.1" 200 None
[2023-05-25 10:26:11][waitress-0][DEBUG] Using selector: EpollSelector
[2023-05-25 10:26:11][waitress-0][DEBUG] Extracting filename data: Blood-Stained Teeth #2 (2022)
[2023-05-25 10:26:11][waitress-0][DEBUG] Extracting filename data: {'series': 'Blood-Stained Teeth', 'year': 2022, 'volume_number': None, 'special_version': None, 'issue_number': 2.0, 'annual': False}
[2023-05-25 10:26:11][waitress-0][DEBUG] Extracting filename data: Blood Stain Vol. 2 (2017)
[2023-05-25 10:26:11][waitress-0][DEBUG] Extracting filename data: {'series': 'Blood Stain', 'year': 2017, 'volume_number': 2, 'special_version': 'tpb', 'issue_number': None, 'annual': False}
[2023-05-25 10:26:11][waitress-0][DEBUG] Matching titles (Blood Stain, Blood-Stained Teeth): False
[2023-05-25 10:26:11][waitress-0][DEBUG] Manual search results: [{'series': 'Blood Stain', 'year': 2017, 'volume_number': 2, 'special_version': 'tpb', 'issue_number': None, 'annual': False, 'link': 'https://getcomics.org/other-comics/blood-stain-vol-2-2017/', 'display_title': 'Blood Stain Vol. 2 (2017)', 'source': 'GetComics', 'match': False, 'match_issue': 'Link is blocklisted'}, {'series': 'Blood-Stained Teeth', 'year': 2022, 'volume_number': None, 'special_version': None, 'issue_number': 2.0, 'annual': False, 'link': 'https://getcomics.org/other-comics/blood-stained-teeth-2-2022/', 'display_title': 'Blood-Stained Teeth #2 (2022)', 'source': 'GetComics', 'match': False, 'match_issue': "Title doesn't match"}]
[2023-05-25 10:26:16][waitress-8][DEBUG] POST /api/issues/47/download
[2023-05-25 10:26:16][waitress-8][INFO] Adding download for volume 12 issue 47: https://getcomics.org/other-comics/blood-stain-vol-2-2017/
[2023-05-25 10:26:16][waitress-8][DEBUG] Extracting download links from https://getcomics.org/other-comics/blood-stain-vol-2-2017/ for volume 12 and issue 47
[2023-05-25 10:26:16][waitress-8][DEBUG] Starting new HTTPS connection (1): getcomics.org:443
[2023-05-25 10:26:16][waitress-8][DEBUG] https://getcomics.org:443 "GET /other-comics/blood-stain-vol-2-2017/ HTTP/1.1" 200 None
[2023-05-25 10:26:16][waitress-8][DEBUG] Extracting download groups
[2023-05-25 10:26:16][waitress-8][DEBUG] Checking download link: https://eight.comicfiles.ru/Other/Others/Collection/Up9/Blood%20Stain%20v02%20%282017%29%20%28Digital-uHD%29%20%28Dogmatix-Empire%29.cbr, download now
[2023-05-25 10:26:16][waitress-8][DEBUG] Checking download link: download now maps to getcomics
[2023-05-25 10:26:16][waitress-8][INFO] Adding https://getcomics.org/other-comics/blood-stain-vol-2-2017/ to blocklist with reason "No supported or working links"
[2023-05-25 10:26:16][waitress-8][DEBUG] Fetching blocklist entry 1
[2023-05-25 10:26:16][waitress-8][WARNING] Unable to extract download links from source

[ajurna]

right, you are spot on with the problem.

it seems to be in the _extract_download_links https://github.com/Casvt/Kapowarr/blob/development/backend/download.py#L603

so when doing a specific volume search its querying the volumes but not the issues. so when it processes the downloads with _process_extracted_get_comics_links it has the wrong volume number and it rejects the download.

[ajurna]

i think the problem is there isn't logic to handle a comic that is a collection of volumes. it will only handle a comic that is a specific volume with multiple or single issues.

so if you had added the comic as blood stain volume 2 then it would download. i think there needs to be a db change here to mark certain volumes as a collection of volumes.