feat(.github): add CARTO features manifest CI verification - #91
Merged
Conversation
- Add standalone carto-features-check.yml workflow that verifies all manifest patterns on upstream-sync pushes and PRs to carto/main - Add manifest awareness to resolver Claude prompt with embedded verification script - Add manifest verification step in resolver between conflict check and merge commit - Add manifest awareness to CI fixer Claude prompt - Fix Azure URL Suffix Stripping pattern to match single-line grep
mateo-di
marked this pull request as ready for review
March 10, 2026 18:05
3 tasks
This was referenced Apr 10, 2026
3 tasks
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
carto-features-check.ymlworkflow that verifies all manifest patterns onupstream-sync/**pushes and PRs tocarto/mainDetails
The features manifest (
.github/carto-features.yml) lists grep-verifiable patterns for all CARTO-specific customizations. This PR wires it into CI so patterns are automatically checked, preventing accidental loss of CARTO patches during upstream merges.9/10 patterns pass on
carto/main— the missing one (Snowflake Full URL Passthrough) will arrive whenupstream-sync/v1.81.0-stablemerges.Shortcut
https://app.shortcut.com/cartoteam/story/536230
Test plan
carto-features-checkworkflow triggers on this PR