fix: implement single-PR workflow for upstream sync conflict resolution - #46
Merged
Merged
Conversation
Changes the upstream sync architecture to use a dedicated sync branch instead of creating PRs directly from main. This enables pushing conflict resolution commits directly to the existing PR. Architecture changes: - upstream-sync.yml: Creates upstream-sync/vX.Y.Z branch from main - resolver.yml: Pushes to existing sync branch instead of creating new PR Benefits: - Single PR workflow (no separate resolution PR) - Cleaner git history - Less confusion about which PR to merge - Deterministic git operations (hardcoded in workflow, not Claude prompt)
Updates documentation to reflect the new upstream sync workflow: - Added single-PR workflow architecture diagram - Updated branch strategy to include upstream-sync/* branches - Added critical merge instructions (never squash/rebase) - Updated conflict resolution troubleshooting - Added resolver workflow to CARTO-specific changes list
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Shortcut
Changes the upstream sync architecture to use a dedicated sync branch instead of creating PRs directly from main. This enables pushing conflict resolution commits directly to the existing PR.
Architecture Change
Before (2 PRs, confusing)
After (1 PR, clean)
Changes
carto-upstream-sync.ymlupstream-sync/vX.Y.Zbranch from main before creating PRcarto-upstream-sync-resolver.ymlBenefits
Type of change
Acceptance
upstream-sync/vX.Y.ZbranchBasic checklist