set precision of TWKB to 5 and fix doc in formatters #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #257659: Change default precision in TWKB to 5. |
Jesus89
approved these changes
Sep 15, 2022
Jesus89
deleted the
feature/sc-257659/change-default-precision-in-twkw-to-5
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shortcut
The builder always parses the TWKB format with precision 5, because the library WKX doesn't give other option. In order to be compatible with carto product, precision has been set to 5 in the TWKB Writer
Type of change
Changed
Fixed
Acceptance
cd clouds/databricksmake deploymake testIn builder create a connection with databricks (where the libraries are deployed) and execute the query:
SELECT ST_CENTROID(geom) as geom FROM carto_dev_data.geography_usa_zcta_2019