-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linter sql and markdown #316
Add linter sql and markdown #316
Conversation
This reverts commit 2d585f9.
This pull request has been linked to Shortcut Story #250230: Add linter SQL and Markdown. |
- `yarn`: https://yarnpkg.com/ (v1.22) | ||
- `bq`: https://cloud.google.com/bigquery/docs/bq-command-line-tool | ||
- `gsutil`: https://cloud.google.com/storage/docs/gsutil (v5.5) | ||
- `make`: <https://www.gnu.org/software/make/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add Python3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Python3
: https://www.python.org/downloads/release/python-3811 (v3.8.11)
…/github.com/CartoDB/carto-spatial-extension into chore/sc-250230/add-linter-sql-and-markdown
Description
Shortcut
Add linters for sql and md files.
Some changes to take into account:
@
so the python code helped to these replacements without intermediate temp files and also to control in which scripts it's failing. I had to add support to python in common for some providers as SF and BQ because of this.Missing linting on pre-commit. Right now linting could take a while for some modules when we add that feature let's make sure only diff files are linted.
Type of change
Acceptance