Swift 4.1: Utilize synthesized Equatable impl #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdiep
approved these changes
Apr 11, 2018
|
Are we ready to require this? If we use it for Carthage, then Carthage will only build on Xcode 9.3 and thus only build on macOS 10.13. 😕 |
|
Good point, so should we still support Xcode 9.2/Swift 4.0 for several months, maybe until Swift 4.2? |
|
Probably—or even until 10.14 is out. 😞 |
|
Let’s make it conditional to ship this quickly. |
ikesyo
force-pushed
the
synthesized-equatable
branch
from
b527ccb to
efb644b
Compare
mdiep
approved these changes
Apr 25, 2018
|
Unfortunately, there's a CI failure. 😞 |
|
Yes, that should be addressed by #127. |
|
Sorry. Hadn't made it to that PR yet. 😅 |
ikesyo
force-pushed
the
synthesized-equatable
branch
from
36e7f61 to
b8a8ff3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.