-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow to automate updating references to Carter NuGet package #304
Merged
jchannon
merged 14 commits into
defaultinterface
from
mderriey/update-carter-package-references
Nov 19, 2022
Merged
Add workflow to automate updating references to Carter NuGet package #304
jchannon
merged 14 commits into
defaultinterface
from
mderriey/update-carter-package-references
Nov 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Might be worth a chat on the Carter Slack channel about these 3 PRs to discuss what we should do going forward? |
jchannon
force-pushed
the
mderriey/update-carter-package-references
branch
from
November 19, 2022 14:54
80e4791
to
e5af5e5
Compare
This reverts commit b3e0e7b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort of related to #298, and discussed in #299 (comment)
This pull request adds a new manual workflow that crawls through the
.csproj
files in the repo and updates references to the Carter NuGet package.The workflow uses the NuGet API to find the latest published version of the package; there's the option of including prerelease versions in the search process.
Lots of junk in the workflow file
Manual workflows can only be run if their workflow file are in the default branch, which is not the case here.
As a result, I added a
push
trigger to test out the process.I've highlighted the portions that will be removed before this gets merged if deemed aceptable.
Edit: that's now been removed in 3448d33
What about the other repositories?
You mentioned that you were interested in having such a process for several repos under the Carter organisation.
This PR deliberately focuses on a single repository, and I've thought about how to use it in several repositories.
If you're happy with this and it gets merged, I'll open a new issue with my thoughts and we can take it further.
Test runs
Here's a run where we include prerelease versions, and commit and push.
We can see it worked nicely, and resulted in b3e0e7b, which looks like it was authored by Jonathan; it was of course reverted in 516dd02.
Changes required before this can get merged