-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional normalization (cont.) #98
Conversation
I just noticed all the unittests are no longer being run upon pr submission. Do we know why? |
Things look good. Can you just provide a way for users to optionally specify a ref_mean and ref_var in the ppo config? You can make them Optional[float] parameters defaulting to false in the PPOMethodConfig |
Also louis will want you to address all his comments from before |
#92 was the last pr on which unittests ran, I can fix it in this pr trlx/.github/workflows/build.yml Line 7 in 12598e9
I think I have haven't I, i.e. running var calculation and storing ref_* |
@LouisCastricato Are you happy with the comments? Once the ppoconfig is modified to accept pre-computed ref_mean, ref_var I'm good to merge |
I think this is ok to merge |
https://wandb.ai/sorry/public/runs/2x8totg2