Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slow ilql eval #91

Merged
merged 4 commits into from
Nov 11, 2022
Merged

Fix slow ilql eval #91

merged 4 commits into from
Nov 11, 2022

Conversation

maxreciprocate
Copy link
Collaborator

This pr

  • puts pipeline on rank 0 gpu to process large validation batch sizes
  • removes stats collection with wandb.Histogram during sampling, since it was redundant and also was slowing down validation

https://wandb.ai/sorry/public/runs/1u2vv56a

@LouisCastricato LouisCastricato merged commit ea38a94 into master Nov 11, 2022
@maxreciprocate maxreciprocate deleted the fix-slow-ilql-eval branch November 15, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants