ILQL loss refactor #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. We should have @shahbuland update the readthedocs though. |
LouisCastricato
approved these changes
Nov 11, 2022
Maybe we should make the CI update them automatically on merge? |
cat-state
added a commit
that referenced
this pull request
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this, we refactor out the ILQL loss function and model additions so they can be reused with other accelerator libraries.
I also refactored the loss to be slightly clearer and fixed some type errors.
First part of #75
W&B run: https://wandb.ai/carperai/trlx/runs/3tam2www