Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds style file and reward function capabilities to ppo orchestrator #8

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

LouisCastricato
Copy link
Contributor

This is in relation to #7 , we added a style file and code of conduct to make contributions easier. Similarly, we added the ability to pass custom reward functions to orchestrators. Note that you can still override the reward function within an orchestrator, but the hope is that this will not be the default going forward.

@LouisCastricato
Copy link
Contributor Author

@Dahoas, we need to update the colab notebook.

Copy link
Collaborator

@maxreciprocate maxreciprocate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LouisCastricato LouisCastricato merged commit 35d3446 into master Oct 5, 2022
@LouisCastricato LouisCastricato deleted the cleaning branch October 5, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants