Minibatch iterator #403
Merged
Minibatch iterator #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eluzhnica
force-pushed
the
minibatch-impl-dataloader
branch
from
0b7df94
to
e83deef
Compare
Merged
|
This looks good to me! |
cat-state
pushed a commit
that referenced
this pull request
Apr 6, 2023
This PR adds gradient accumulation and minibatching to the accelerate trainers. * fixes half exp not implemented error * added minibatching * fix num_mb name * fix minibatch indexing * fixing style * fixing style * fixing style * Minibatch iterator (#403) * Add minibatch iterator * Add tests * Avoid gradient synchronization when accumulating (#396) * Avoid gradient synchronization when accumulating * Fix accumulation to account for dataloader * Add some tests --------- Co-authored-by: Enxhell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds compatibility for ILQL, SFT and PPO