Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Add optional dependency list #381

Merged
merged 1 commit into from
Mar 21, 2023
Merged

[feat] Add optional dependency list #381

merged 1 commit into from
Mar 21, 2023

Conversation

maxreciprocate
Copy link
Collaborator

This PR adds an optional dependency list (torch==2.0.0, accelerate==0.17.1, transformers==4.27.1, etc) for reproducable runs.

cat-state
cat-state approved these changes Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@cat-state cat-state left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to make this a target in setup.cfg? then its all in one place. LGTM otherwise

@maxreciprocate
Copy link
Collaborator Author

Reached agreement to keep pinned dependencies in requirements.txt

[0] https://caremad.io/posts/2013/07/setup-vs-requirement/

@maxreciprocate maxreciprocate merged commit b0c4ea9 into main Mar 21, 2023
@maxreciprocate maxreciprocate deleted the add-dependencies-pin branch March 21, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cat-state cat-state cat-state approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxreciprocate @cat-state