Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hypothesis tests for ILQL and fix edge cases #370

Merged
merged 14 commits into from
Mar 28, 2023
Merged

Conversation

cat-state
Copy link
Collaborator

@cat-state cat-state commented Mar 16, 2023

Adds more tests for ILQL heads and data preprocessing. Also adds usage of hypothesis for generating test cases. To make the tests pass, I slightly refactored the ILQL preprocessing to cleanly handle edge cases.

report: https://wandb.ai/carperai/trlx/reports/ilql-testing-refactor--VmlldzozNzk5NDIx

@cat-state cat-state changed the title Add hypothesis tests for ILQL Add hypothesis tests for ILQL and fix edge cases Mar 16, 2023
Copy link
Collaborator

@maxreciprocate maxreciprocate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Aman, this is so cool actually! I've checked that tests pass and there seem to be no regressions, except for a small difference with main in trimming <eos>

https://wandb.ai/sorry/trlx-references/reports/add-hypothesis-v-main--VmlldzozODY0OTY2#ilql_sentiments/gpt2/1gpu

trlx/pipeline/offline_pipeline.py Show resolved Hide resolved
Copy link
Collaborator

@maxreciprocate maxreciprocate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maxreciprocate maxreciprocate merged commit 9d85215 into main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants