-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hypothesis
tests for ILQL and fix edge cases
#370
Conversation
hypothesis
tests for ILQLhypothesis
tests for ILQL and fix edge cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Aman, this is so cool actually! I've checked that tests pass and there seem to be no regressions, except for a small difference with main in trimming <eos>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Adds more tests for ILQL heads and data preprocessing. Also adds usage of
hypothesis
for generating test cases. To make the tests pass, I slightly refactored the ILQL preprocessing to cleanly handle edge cases.report: https://wandb.ai/carperai/trlx/reports/ilql-testing-refactor--VmlldzozNzk5NDIx