Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable infinite dataloader for prompt_dataloader in PPO Trainer #358

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Enable infinite dataloader for prompt_dataloader in PPO Trainer #358

merged 2 commits into from
Mar 21, 2023

Conversation

alexandremuzio
Copy link
Contributor

Add infinite flag to PromptPipeline to enable cyclic pipeline behavior.
This fixes a TODO in the accelerate_ppo_trainer.py.

@alexandremuzio
Copy link
Contributor Author

Seems like there's possibly a bug in the accelerate/data_loader/BatchSamplerShard which doesn't play well with infinite sized pipelines. Reverting to separate function infinite_dataloader solution

@alexandremuzio alexandremuzio changed the title Enable infinite PromptPipeline Enable infinite dataloader for prompt_dataloader in PPO Trainer Mar 7, 2023
cat-state
cat-state approved these changes Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@cat-state cat-state left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexandremuzio !

@cat-state cat-state merged commit cc52edb into CarperAI:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cat-state cat-state cat-state approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandremuzio @cat-state