-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use attrs/cattrs instead of custom serialization #333
Draft
cat-state
wants to merge
15
commits into
main
Choose a base branch
from
switch-to-attrs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converting to draft for discussion around refactoring and config breakage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #306
This PR adds cattrs and attrs usage to remove us having to write custom ser/des code.
To keep supporting the ability to define
MethodConfig
s and*Trainer
s outside TRLX however, we need to keep some of the custom serialization/deserialization (rather than just making aUnion
of all the relevant config types and having cattrs deserialize it)As a further improvement, we could make
*TrainerConfig
classes as we have forMethodConfig
, and instantiate the trainers from a method on the deserialized*TrainerConfig
, rather than a singleTrainConfig
with a stringly-typed name of the trainer class to instantiate. This would also let us give the different trainers different args as they need rather than getting trainer specific args fromMethodConfig
(likegen_kwargs
)