Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove example usage of deprecating trlx.train dataset arg #331

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

jon-tow
Copy link
Collaborator

@jon-tow jon-tow commented Feb 23, 2023

Quick fix to remove all dataset args to trlx.train to avoid promoting deprecating usage.

  • If dataset is provided, the default behavior is to load the SFT config even though ILQL could be the intended method (see simulacra notebook).

    trlx/trlx/trlx.py

    Lines 57 to 62 in 165422d

    if reward_fn:
    config = TRLConfig.load_yaml("configs/ppo_config.yml")
    elif rewards:
    config = TRLConfig.load_yaml("configs/ilql_config.yml")
    else:
    config = TRLConfig.load_yaml("configs/sft_config.yml")

Copy link
Collaborator

@cat-state cat-state left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@cat-state cat-state merged commit 4e7b395 into CarperAI:main Feb 23, 2023
@jon-tow jon-tow deleted the update-deprecated-args branch February 23, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants