Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[style] Increase black's line length #250

Merged
merged 3 commits into from
Feb 1, 2023
Merged

Conversation

maxreciprocate
Copy link
Collaborator

This PR bumps black's allowed line width in order to clean up sometimes awkward line breaks accumulated so far, yielding -400 LoC total as a result.

for some odd reason CI's style check differs from the local `run --all-files`
Copy link
Collaborator

@jon-tow jon-tow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Let's fix the isort issue once and for all (see suggestion below) and get this merged.

@@ -5,3 +5,6 @@ build-backend = "setuptools.build_meta"
[tool.isort]
multi_line_output = 3
profile = "black"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix the isort issue add trlx to the source paths:

[tool.isort]
src_paths="trlx"
...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to fix this starting from a fresh git clone instead without adding this instruction, so that's probably affected only me locally

Copy link
Collaborator

@jon-tow jon-tow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jon-tow jon-tow merged commit 4390d3f into main Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants