Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tokenizer missing form config.to_dict() #228

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Fix tokenizer missing form config.to_dict() #228

merged 1 commit into from
Jan 27, 2023

Conversation

alan-cooney
Copy link
Contributor

@alan-cooney alan-cooney commented Jan 26, 2023 •
edited
Loading

Fixes the missing property, which was breaking some use cases where hyperparameters are being tuned with Ray

Also orders alphabetically.

jon-tow
jon-tow approved these changes Jan 27, 2023
View reviewed changes
Copy link
Collaborator

@jon-tow jon-tow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

@jon-tow jon-tow merged commit aeab7cc into CarperAI:main Jan 27, 2023
@alan-cooney alan-cooney deleted the fixTokenizerConfig branch January 27, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jon-tow jon-tow jon-tow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alan-cooney @jon-tow