Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add devcontainer support #196

Merged
merged 5 commits into from
Jan 27, 2023
Merged

Conversation

alan-cooney
Copy link
Contributor

Add Devcontainer support so that contributors can setup a working development environment with one click (e.g. with GitHub Codespaces or VS Code Remote Development Pack).

Includes CUDA support.

Add [Devcontainer](https://containers.dev/) support so that contributors can setup a working development environment with one click (e.g. with [GitHub Codespaces](https://github.com/features/codespaces) or [VS Code Remote Development Pack](https://marketplace.visualstudio.com/items?itemName=ms-vscode-remote.vscode-remote-extensionpack)).

Includes CUDA support.
@jon-tow
Copy link
Collaborator

jon-tow commented Jan 16, 2023

Cool! @alan-cooney I'm not too familiar with GH codespaces and how this actually works. Is there a simple guide for me (and others) to set this up and try "locally" before merging?

@alan-cooney
Copy link
Contributor Author

Hi @jon-tow - it's really just a Docker image (i.e. with all underlying dependencies such as Python and CUDA), plus a few niceties e.g. running pip install.

If you want to try this locally with VS Code, follow https://code.visualstudio.com/docs/devcontainers/containers#_getting-started (just the installation part) and then if you clone this PR it'll automatically give you the option to run in a devcontainer. If you want to try with Codespaces, you can do this on https://github.com/skyhookadventure/trlx/tree/devcontainer by clicking Code (green button) -> Codespaces -> add (or "..." , "add with options" and then choose a GPU machine if you have access).

Copy link
Collaborator

@jon-tow jon-tow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging as it seems useful for convenient dev setups. Thanks again @alan-cooney

@jon-tow jon-tow merged commit b2ce1a4 into CarperAI:main Jan 27, 2023
@alan-cooney alan-cooney deleted the devcontainer branch January 27, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants