Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the config loading consistent across all example scripts. #192

Merged
merged 3 commits into from
Jan 17, 2023

Conversation

shermansiu
Copy link
Contributor

Rewriting the config loading like this ensures that the examples can be called from anywhere. Moreover, file streams are properly closed after the file contents are retrieved.

Rewriting the config loading like this ensures that the examples can be called from anywhere. Moreover, file streams are properly closed after the file contents are retrieved.
@jon-tow jon-tow self-requested a review January 17, 2023 16:54
Copy link
Collaborator

@jon-tow jon-tow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up! I've updated some of the more recent examples.

@jon-tow jon-tow merged commit 94adc05 into CarperAI:main Jan 17, 2023
@shermansiu shermansiu deleted the clean-example-config-loading branch January 19, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants