Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pre-commit version and add isort #152

Merged
merged 7 commits into from
Dec 29, 2022
Merged

Update pre-commit version and add isort #152

merged 7 commits into from
Dec 29, 2022

Conversation

jon-tow
Copy link
Collaborator

@jon-tow jon-tow commented Dec 27, 2022 •
edited
Loading

This PR adds the following pre-commit updates:

  • Update pre-commit-hook to a more recent version.
  • Adds black formatting to tests directory as it was never updated for the name change from unittests➡️tests
  • Adds isort to the pre-commit action runner. This is to avoid waiting on Add isort flake8 #39 for the more involved flake8 checks which will require working around torchtyping.

@jon-tow jon-tow changed the title Update pre-commit version and repos Update pre-commit version and add isort Dec 27, 2022
LouisCastricato
LouisCastricato reviewed Dec 27, 2022
View reviewed changes
trlx/utils/loading.py Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@LouisCastricato LouisCastricato merged commit 974d9a9 into CarperAI:main Dec 29, 2022
@jon-tow jon-tow deleted the update-pre-commit branch December 29, 2022 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cat-state cat-state cat-state approved these changes

@LouisCastricato LouisCastricato LouisCastricato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jon-tow @LouisCastricato @cat-state