Add BloomModel hydra support
#129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LouisCastricato
approved these changes
Dec 9, 2022
|
@Dahoas can you give this a quick glance |
|
Bloom rewards seem a bit low relative to other models :(. But Not much we can really do I guess |
|
To he expected |
Dahoas
approved these changes
Dec 9, 2022
| # 1.0 in head_mask indicate we keep the head | ||
| # attention_probs has shape batch_size x num_heads x N x N | ||
| # head_mask has shape n_layer x batch x num_heads x N x N | ||
| head_mask = self.get_head_mask(head_mask, hf_get_num_hidden_layers(self.config)) |
There was a problem hiding this comment.
The head mask is a binary mask that can be used to drop the self-attention weights (softmax(qk)) from specified heads before computing the full attention output. For example, see here. get_head_mask just expands the dimensions to line-up with proper shape.
| else: | ||
| attention_mask = attention_mask.to(hidden_states.device) | ||
|
|
||
| alibi = modeling_bloom.build_alibi_tensor( |
There was a problem hiding this comment.
I didn't know bloom used alibi
|
Looks good to me! I just left some questions so I can better understand how things are functioning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds hydra-based PPO model branching support for
BloomModels.wandbreports:Note: The
<Arch>ModelBranchimplementations should be refactored in the future to share a common interface if we plan on adding more in the near future.