Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests to ensure valid example configs #120

Merged
merged 4 commits into from
Dec 3, 2022
Merged

Conversation

jon-tow
Copy link
Collaborator

@jon-tow jon-tow commented Dec 1, 2022

This PR adds the following configuration and example updates:

  • Adds unit tests to ensure future config changes do not break examples. Note that this requires TRL config YAMLs to be located in directories named configs. (This might need to be updated if we decide to integrate OmegaConf/Hydra for config management.)
  • Adds method config options, scale_reward, ref_mean, ref_std, and cliprange_reward to appropriate PPO configs.
  • Fixes examples/experiments/grounded_program_synthesis missing dataset directory error.

Awaiting #109

@jon-tow jon-tow changed the title Fix invalid configs and update broken examples Add unit tests to ensure valid example configs Dec 1, 2022
@LouisCastricato
Copy link
Contributor

This looks great! Does it work with GitHub CI?

@jon-tow
Copy link
Collaborator Author

jon-tow commented Dec 3, 2022

Yup! I just double checked CI (see here)

@LouisCastricato LouisCastricato merged commit b60f05e into main Dec 3, 2022
@jon-tow jon-tow deleted the update-configs branch December 3, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants