Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set seed after default config instantiation #114

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Set seed after default config instantiation #114

merged 1 commit into from
Nov 28, 2022

Conversation

jon-tow
Copy link
Collaborator

@jon-tow jon-tow commented Nov 28, 2022

  • set_seed(config.train.seed) fails if no config is passed to the train function as a default config must be created first.

maxreciprocate
maxreciprocate approved these changes Nov 28, 2022
View reviewed changes
Copy link
Collaborator

@maxreciprocate maxreciprocate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jon-tow jon-tow merged commit dae101e into main Nov 28, 2022
@jon-tow jon-tow deleted the fix-seed-config branch December 1, 2022 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxreciprocate maxreciprocate maxreciprocate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jon-tow @maxreciprocate