Skip to content

clippy + local pipeline #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fbielejec merged 2 commits into from
Mar 2, 2023
Merged

clippy + local pipeline #959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ff273d
clippy + local pipeline
fbielejec Mar 2, 2023
1a0fe9b
update local image
fbielejec Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/scripts/run_smartnet.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

set -e

export NODE_IMAGE=public.ecr.aws/p6e8q1z1/feature-env-aleph-node:fe-benjamin_c643069
export NODE_IMAGE=public.ecr.aws/p6e8q1z1/aleph-node:latest

# key derived from "//0"
export NODE_ID=5D34dL5prEUaGNQtPPZ3yN5Y6BnkfXunKXXz6fo7ZJbLwRRH
Expand Down
2 changes: 1 addition & 1 deletion contracts/simple_dex/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,7 @@ mod simple_dex {
balance_token_out
.checked_sub(op4)
// If the division is not even, leave the 1 unit of dust in the exchange instead of paying it out.
.and_then(|result| result.checked_sub(if op3 % op2 > 0 { 1 } else { 0 }))
.and_then(|result| result.checked_sub((op3 % op2 > 0).into()))
.ok_or(DexError::Arithmethic)
}

Expand Down
2 changes: 1 addition & 1 deletion docker/smartnet-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ services:
- PURGE_BEFORE_START=true
- RPC_PORT=9933
- RUST_LOG=info
- UNIT_CREATION_DELAY=50
- UNIT_CREATION_DELAY=300
- WS_PORT=9943
- BOOT_NODES=/ip4/127.0.0.1/tcp/30333/p2p/$BOOTNODE_PEER_ID
- PUBLIC_ADDR=/ip4/127.0.0.1/tcp/30333
Expand Down
8 changes: 8 additions & 0 deletions scripts/run_checks_on_excluded_packages.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,14 @@ packages=(
"fork-off"
"benches/payout-stakers"
"bin/cliain"
"contracts/access_control"
"contracts/button"
"contracts/game_token"
"contracts/marketplace"
"contracts/simple_dex"
"contracts/ticket_token"
"contracts/wrapped_azero"
"contracts/adder, "
)

for p in ${packages[@]}
Expand Down