Skip to content

Remove pub(crate) from aleph-client #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pmikolajczyk41 merged 4 commits into from
Jan 9, 2023
Merged

Remove pub(crate) from aleph-client #849

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e6fabf1
Remove `pub(crate)`
pmikolajczyk41 Jan 9, 2023
66a3417
Don't expose client
pmikolajczyk41 Jan 9, 2023
1855f5a
Revert "Don't expose client"
pmikolajczyk41 Jan 9, 2023
6aaf17f
Bump
pmikolajczyk41 Jan 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions aleph-client/src/connections.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,13 @@ pub struct RootConnection {
connection: SignedConnection,
}

pub(crate) trait AsConnection {
/// Castability to a plain connection.
pub trait AsConnection {
fn as_connection(&self) -> &Connection;
}

pub(crate) trait AsSigned {
/// Castability to a signed connection.
pub trait AsSigned {
fn as_signed(&self) -> &SignedConnection;
}

Expand Down Expand Up @@ -337,7 +339,7 @@ impl Connection {
}
}

pub(crate) fn as_client(&self) -> &SubxtClient {
pub(super) fn as_client(&self) -> &SubxtClient {
&self.client
}
}
Expand Down
2 changes: 1 addition & 1 deletion aleph-client/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ pub type Client = OnlineClient<AlephConfig>;
/// An alias for a hash type.
pub type BlockHash = H256;

pub(crate) type SubxtClient = OnlineClient<AlephConfig>;
type SubxtClient = OnlineClient<AlephConfig>;

pub use connections::{
Connection, ConnectionApi, RootConnection, SignedConnection, SignedConnectionApi, SudoCall,
Expand Down