Merged
Conversation
pmikolajczyk41
approved these changes
Jan 10, 2023
Contributor
pmikolajczyk41
left a comment
pmikolajczyk41
left a comment
There was a problem hiding this comment.
lgtm, but maybe before following up with 2to1, I suggest creating SC with this preimage, just to measure time needed for this computation
Contributor
Author
Sure, there is this task that I will take next: https://cardinal-cryptography.atlassian.net/browse/A0-1841 |
Contributor
|
regarding SC costs, you might find #852 helpful |
mike1729
suggested changes
Jan 11, 2023
Contributor
mike1729
left a comment
mike1729
left a comment
There was a problem hiding this comment.
A couple comments but nothing big. Great work to make it work!
deuszx
reviewed
Jan 11, 2023
Co-authored-by: deuszx <95355183+deuszx@users.noreply.github.com>
mike1729
approved these changes
Jan 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An instance of a (parameterized) Poseidon hash function to be used with the relations crate.
Type of change
Checklist:
spec_versionandtransaction_version