Skip to content

Add logging about ABFT version #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timorl merged 3 commits into from
Dec 21, 2022
Merged

Add logging about ABFT version #823

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9b54bd
Add logging about ABFT version
Dec 21, 2022
430b81e
Legacy-only log
Dec 21, 2022
ab6cfc5
Merge branch 'main' into sick-s....
Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions finality-aleph/src/party/manager/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use std::{collections::HashSet, marker::PhantomData, sync::Arc};
use aleph_primitives::{AlephSessionApi, KEY_TYPE};
use async_trait::async_trait;
use futures::channel::oneshot;
use log::{debug, trace, warn};
use log::{debug, info, trace, warn};
use sc_client_api::Backend;
use sp_consensus::SelectChain;
use sp_keystore::CryptoStore;
Expand Down Expand Up @@ -344,9 +344,18 @@ where
.next_session_finality_version(&BlockId::Number(last_block_of_previous_session))
{
#[cfg(feature = "only_legacy")]
_ if self.only_legacy() => self.legacy_subtasks(params),
Ok(version) if version == CURRENT_VERSION => self.current_subtasks(params),
Ok(version) if version == LEGACY_VERSION => self.legacy_subtasks(params),
_ if self.only_legacy() => {
info!(target: "aleph-party", "Running session with legacy-only AlephBFT version.");
self.legacy_subtasks(params)
}
Ok(version) if version == CURRENT_VERSION => {
info!(target: "aleph-party", "Running session with AlephBFT version {}, which is current.", version);
self.current_subtasks(params)
}
Ok(version) if version == LEGACY_VERSION => {
info!(target: "aleph-party", "Running session with AlephBFT version {}, which is legacy.", version);
self.legacy_subtasks(params)
}
Ok(version) => {
panic!("Unsupported version {}. Supported versions: {} or {}. Potentially outdated node.", version, LEGACY_VERSION, CURRENT_VERSION)
}
Expand Down