Added pending_rewards API call to Testnet 8.X branch#782
Merged
Marcin-Radecki merged 1 commit intorelease-8from Dec 5, 2022
Merged
Added pending_rewards API call to Testnet 8.X branch#782Marcin-Radecki merged 1 commit intorelease-8from
Marcin-Radecki merged 1 commit intorelease-8from
Conversation
DamianStraszak
approved these changes
Dec 2, 2022
Contributor
DamianStraszak
left a comment
DamianStraszak
left a comment
There was a problem hiding this comment.
I'm not sure about 44 -- this then changes our policy about bumping by one in our PRs, i.e., we need to jump over 44 in this case.
I guess it's fine, but could you please spread awareness somehow (writing on dev-core or something)?
Marcin-Radecki
added a commit
that referenced
this pull request
Dec 12, 2022
Marcin-Radecki
added a commit
that referenced
this pull request
Dec 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a slightly modified port of #778 to Testnet 8.X brach
Runtime
spec_versionis 44 which might sound controversial, but we need to use the first free number that is not used. This ie because spec_version needs to identify uniquely aleph-runtime, just in case of wrongly updated runtime on Tesnet or Mainnet.