Authorities are staking finalization stall

.github/actions/run-e2e-test/action.yml

@@ -72,7 +72,7 @@ runs:
 
         RESERVED_SEATS="${{ inputs.reserved-seats }}"
         NON_RESERVED_SEATS="${{ inputs.non-reserved-seats }}"
-
+        
         if [[ -n "${RANDOMIZED}" ]]; then
           ARGS+=(-r "${RANDOMIZED}")
         fi

.github/scripts/run_consensus.sh

@@ -5,13 +5,13 @@ set -euo pipefail
 # default node count
 # change when increasing the number of node containers
 NODE_COUNT=5
+# max node count that will not crash current GH machines
+MAX_NODE_COUNT=6
+# default minimum validator count
 MIN_VALIDATOR_COUNT=4
 DOCKER_COMPOSE=${DOCKER_COMPOSE:-"docker/docker-compose.yml"}
 OVERRIDE_DOCKER_COMPOSE=${OVERRIDE_DOCKER_COMPOSE:-""}
 
-# default minimum validator count
-MIN_VALIDATOR_COUNT=4
-
 export NODE_IMAGE=aleph-node:latest
 
 mkdir -p docker/data/
@@ -50,6 +50,11 @@ done
 
 export NODE_COUNT
 
+if [[${NODE_COUNT} -gt ${MAX_NODE_COUNT}]]; then
+  echo "Tried to run ${NODE_COUNT}. Max node count allowed: ${MAX_NODE_COUNT}."
+  exit 1
+fi
+
 function generate_authorities {
   local authorities_count="$1"
 

.github/workflows/e2e-tests-main-devnet.yml

@@ -454,7 +454,7 @@ jobs:
           node-count: 6
           reserved-seats: 3
           non-reserved-seats: 3
-          follow-up-finalization-check: false
+          follow-up-finalization-check: true
         timeout-minutes: 15
 
   run-e2e-ban-automatic:

docker/docker-compose.base.yml

@@ -77,3 +77,19 @@ services:
       # key derived from "//4"
       - BASE_PATH=/data/5DiDShBWa1fQx6gLzpf3SFBhMinCoyvHM1BWjPNsmXS8hkrW
       - NODE_KEY_PATH=/data/5DiDShBWa1fQx6gLzpf3SFBhMinCoyvHM1BWjPNsmXS8hkrW/p2p_secret
+
+  Node5:
+    extends:
+      file: common.yml
+      service: AlephNonBootNode
+    container_name: Node5
+    environment:
+      - RPC_PORT=9938
+      - WS_PORT=9948
+      - PORT=30338
+      - VALIDATOR_PORT=30348
+      - PUBLIC_VALIDATOR_ADDRESS=127.0.0.1:30348
+      - NAME=Node5
+      # key derived from "//5"
+      - BASE_PATH=/data/5EFb84yH9tpcFuiKUcsmdoF7xeeY3ajG1ZLQimxQoFt9HMKR
+      - NODE_KEY_PATH=/data/5EFb84yH9tpcFuiKUcsmdoF7xeeY3ajG1ZLQimxQoFt9HMKR/p2p_secret

docker/docker-compose.bridged.yml

@@ -53,6 +53,17 @@ services:
       - PUBLIC_VALIDATOR_ADDRESS=Node4:30347
       - BOOT_NODES=/dns4/Node0/tcp/30333/p2p/$BOOTNODE_PEER_ID
 
+  Node5:
+    extends:
+      file: docker-compose.base.yml
+      service: Node5
+    networks:
+      - main
+      - Node5
+    environment:
+      - PUBLIC_VALIDATOR_ADDRESS=Node4:30348
+      - BOOT_NODES=/dns4/Node0/tcp/30333/p2p/$BOOTNODE_PEER_ID
+
 networks:
   main:
     name: main-network
@@ -66,3 +77,5 @@ networks:
     name: Node3-network
   Node4:
     name: Node4-network
+  Node5:
+    name: Node5-network

docker/docker-compose.yml

@@ -30,3 +30,9 @@ services:
       file: docker-compose.base.yml
       service: Node4
     network_mode: host
+
+  Node5:
+    extends:
+      file: docker-compose.base.yml
+      service: Node5
+    network_mode: host

e2e-tests/docker_entrypoint.sh

@@ -11,7 +11,9 @@ fi
 
 # If test case params are both not empty, run client with them. Otherwise, run without params.
 if [[ -n "${RESERVED_SEATS:-}" && -n "${NON_RESERVED_SEATS:-}" ]]; then
+  VALIDATOR_COUNT = $((${RESERVED_SEATS} + ${NON_RESERVED_SEATS}))
   ARGS+=(
+    --validator-count "${VALIDATOR_COUNT}"
     --reserved-seats "${RESERVED_SEATS}"
     --non-reserved-seats "${NON_RESERVED_SEATS}"
   )