Chain extension: unit tests #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xtension/tests # Conflicts: # bin/runtime/src/chain_extension/mod.rs # pallets/snarcos/src/benchmarking/mod.rs
DamianStraszak
approved these changes
Nov 14, 2022
deuszx
reviewed
Nov 14, 2022
|
I guess that we are looking forward to see rust-lang/rust#95174 stabilized soon... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
SnarcosChainExtensionthrough abstracting awayEnvironmentandRuntime,SnarcosChainExtensionthat ensure correct charging, arguments reading and error passingThere is (at least) one controversial thing here - unstable feature of additional constant generics. It was introduced because all the main calls (
pallet_snarcos::(store_key|verify)) are invoked as static methods ofRuntime. Therefore, it makes testing different behaviors highly inconvenient (since we cannot change the mock behavior depending on any variable). Being able to introduce enums into generics gives us the possibility of concise defining scenarios.