A0-1455: Connection multiplexing in validator network#709
Closed
timorl wants to merge 4 commits intoCardinal-Cryptography:mainfrom
timorl:A0-1455-b-map
Closed
A0-1455: Connection multiplexing in validator network#709timorl wants to merge 4 commits intoCardinal-Cryptography:mainfrom timorl:A0-1455-b-map
timorl wants to merge 4 commits intoCardinal-Cryptography:mainfrom
timorl:A0-1455-b-map
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace the approach with two connections for every pair of validators, one for sending the other for receiving, with a asymmetric single multiplexed connection. This PR is slightly too big, so I'll try splitting it into smaller for review, putting it up only for reference.
A lot of the code is just backwards compatibility, which is annoyingly complex.
Type of change
Please delete options that are not relevant.
Checklist: