Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a fallback when the type is not provided by the IDP (like AAD) #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arheom
Copy link

@arheom arheom commented Jan 10, 2023

Adding a fallback when the type is not provided by the IDP (like AAD) by checking the existing records, as first the users and groups are added and then the group associations.

…, by checking the existing records, as first the users and groups are added and then the group associations.
@Captain-P-Goldfish
Copy link
Owner

sorry for the very late reply.
I do not think that this solution will work smoothly. There might be some environments with a large amount of groups. So if this is really necessary for some providers I would prefer a way like this one:

EntityManager entityManager = getEntityManager(keycloakSession);
Query query = entityManager.createQuery("select g from GroupEntity g where g.id in :groupIds").setParameter("groupIds", memberIds)...;

This one would be much preferable.

@arheom
Copy link
Author

arheom commented Feb 3, 2023

Looks good! I can make the change and test on our environments to make sure all work well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants