Skip to content

VS2017 fixes#663

Merged
speth merged 2 commits intomasterfrom
vs2017_fixes
Jun 27, 2019
Merged

VS2017 fixes#663
speth merged 2 commits intomasterfrom
vs2017_fixes

Conversation

@bryanwweber
Copy link
Copy Markdown
Member

Changes proposed in this pull request:

For VS2017, we need fixes from jbeder/yaml-cpp#597 to compile the submodule
Without this initialization, VS2017 (VC 14.1) complains there is a missing default constructor for UnitSystem.
@bryanwweber
Copy link
Copy Markdown
Member Author

I accidentally pushed this branch to Cantera/cantera instead of bryanwweber/cantera, so I deliberately canceled the (duplicate) appveyor/branch build

@speth speth merged commit 8502d18 into master Jun 27, 2019
@bryanwweber bryanwweber deleted the vs2017_fixes branch December 8, 2019 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants