Some CLib/sourcegen/dotnet updates #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1773 +/- ##
========================================
Coverage 73.23% 73.23%
========================================
Files 381 381
Lines 54343 54216 -127
Branches 9246 9235 -11
========================================
- Hits 39796 39705 -91
+ Misses 11573 11545 -28
+ Partials 2974 2966 -8 ☔ View full report in Codecov by Sentry. |
ischoegl
force-pushed
the
update-dotnet
branch
4 times, most recently
from
e614dd3
to
ba7ece0
Compare
ischoegl
changed the title
ischoegl
force-pushed
the
update-dotnet
branch
2 times, most recently
from
881bdbd
to
c7e588b
Compare
|
🎉 ... figuring out .NET and sourcegen took a while, but this is now ready for a review. |
5 tasks
As of Cantera 3.1, the clib interface is considered experimental, where breakages are acceptable.
Also fix some crosswalk instances
Also remove associated *_del methods as objects are managed by owning Solution instance.
ischoegl
force-pushed
the
update-dotnet
branch
from
79fac04
to
fd66ed6
Compare
|
@speth … thanks for your review! I rebased and addressed your comments, so it should be ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
This PR introduces combines some simple CLib updates with required fixes/updates in
sourcegenanddotnet(with inconsequential changes in MATLAB)thermo_newFromFilefrom CLib and .NETthermo_equilibratesolver specification from magic number to string (consistent with Python and Fortran APIs)The PR cherry-picks/reimplements some relevant commits from #1761, #1765 and #1770.
If applicable, fill in the issue number this pull request is fixing
Closes #1450, closes Cantera/enhancements#199 (.NET side)
If applicable, provide an example illustrating new features this pull request is introducing
N/A
Checklist
scons build&scons test) and unit tests address code coverage