Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporating the LMR-R mixture rule into Cantera for the first time #1710

Open
wants to merge 92 commits into
base: main
Choose a base branch
from

added singal2024 placeholder to cantera.bib and updated citation in L…

0eb6e58
Select commit
Loading
Failed to load commit list.
Open

Incorporating the LMR-R mixture rule into Cantera for the first time #1710

added singal2024 placeholder to cantera.bib and updated citation in L…
0eb6e58
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 17, 2024 in 0s

72.87% (-0.37%) compared to ec0cfdb

View this Pull Request on Codecov

72.87% (-0.37%) compared to ec0cfdb

Details

Codecov Report

Attention: Patch coverage is 0.78740% with 252 lines in your changes missing coverage. Please review.

Project coverage is 72.87%. Comparing base (ec0cfdb) to head (0eb6e58).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/kinetics/LinearBurkeRate.cpp 0.00% 224 Missing ⚠️
include/cantera/kinetics/LinearBurkeRate.h 0.00% 15 Missing ⚠️
interfaces/cython/cantera/reaction.pyx 14.28% 12 Missing ⚠️
src/kinetics/ReactionRateFactory.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1710      +/-   ##
==========================================
- Coverage   73.23%   72.87%   -0.37%     
==========================================
  Files         381      383       +2     
  Lines       54375    54616     +241     
  Branches     9251     9282      +31     
==========================================
- Hits        39823    39802      -21     
- Misses      11580    11832     +252     
- Partials     2972     2982      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov