Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smart clib cabinets / add Solution to clib API #1448

Merged
merged 31 commits into from
Mar 7, 2023
Merged

Smart clib cabinets / add Solution to clib API #1448

merged 31 commits into from
Mar 7, 2023

Commits on Mar 2, 2023

  1. [test-problems] Fix clib-test.c 

    Mole fractions have to be set before T and P; otherwise, the pressure
changes. Before the change, the pressure was significantly lower than
5 atm. Also fix incorrect use of 'kin_newFromFile', which causes
unintended linkages to default objects that do not raise exceptions
but may lead to erroneous results.
    @ischoegl
    ischoegl committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    f695ea6 View commit details
    Browse the repository at this point in the history

  2. [clib] Implement SharedCabinet using shared_ptr list

    @ischoegl
    ischoegl committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    5eede14 View commit details
    Browse the repository at this point in the history

  3. [clib] Implement methods using SolutionCabinet

    @ischoegl
    ischoegl committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    54a9360 View commit details
    Browse the repository at this point in the history

  4. [Transport] Deprecate legacy factory constructors

    @ischoegl
    ischoegl committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    a315281 View commit details
    Browse the repository at this point in the history

  5. [clib] Switch TransportCabinet to smart pointers

    @ischoegl
    ischoegl committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    c11f6b4 View commit details
    Browse the repository at this point in the history

  6. [Kinetics] Change smart pointer type for newKinetics

    @ischoegl
    ischoegl committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    3d3501f View commit details
    Browse the repository at this point in the history

  7. [clib] Switch KineticsCabinet to smart pointers

    @ischoegl
    ischoegl committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    ebb8e26 View commit details
    Browse the repository at this point in the history

  8. [Thermo] Add factory methods returning shared_ptr

    @ischoegl
    ischoegl committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    7065269 View commit details
    Browse the repository at this point in the history

  9. [clib] Switch ThermoCabinet to smart pointers

    @ischoegl
    ischoegl committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    6f40d73 View commit details
    Browse the repository at this point in the history

  10. [clib] Add Reactor::insert to clib 

    Also add service functions for testing cabinet sizes
    @ischoegl
    ischoegl committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    5b97aef View commit details
    Browse the repository at this point in the history

  11. [Kinetics] Update factory constructors

    @ischoegl
    ischoegl committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    3907a15 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2023

  1. [Kinetics] Deprecate non-default constructors

    @ischoegl
    ischoegl committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    fc5719c View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2023

  1. [Kinetics] Used shared pointers in Kinetics::addPhase

    @ischoegl
    ischoegl committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    e0604cd View commit details
    Browse the repository at this point in the history

  2. [oneD] Enable Kinetics/Transport setters for smart pointers

    @ischoegl
    ischoegl committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    7c46ca3 View commit details
    Browse the repository at this point in the history

  3. [clib] Construct ctonedim from smart pointers

    @ischoegl
    ischoegl committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    be944d5 View commit details
    Browse the repository at this point in the history

  4. [clib] Shorten solution_ prefix to soln_ 

    Also:
- add soln_newInterface
- rename solution_newFromFile to soln_newSolution.
    @ischoegl
    ischoegl committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    17c1c6c View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2023

  1. [Thermo] Shorten newThermoBase to newThermo

    @ischoegl
    ischoegl committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    dbdff61 View commit details
    Browse the repository at this point in the history

  2. [clib] Adopt review comments

    @ischoegl
    ischoegl committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    19ccef0 View commit details
    Browse the repository at this point in the history

  3. [fortran] Switch to smart clib cabinets

    @ischoegl
    ischoegl committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    5c3b07a View commit details
    Browse the repository at this point in the history

  4. [unittests] Remove legacy factory methods

    @ischoegl
    ischoegl committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    ec05d85 View commit details
    Browse the repository at this point in the history

  5. [test-problems] Replace legacy factory methods

    @ischoegl
    ischoegl committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    c7c2f0a View commit details
    Browse the repository at this point in the history

  6. [Python] Update API

    @ischoegl
    ischoegl committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    8039649 View commit details
    Browse the repository at this point in the history

  7. [unittest] Implement gtest for 'test-clib' 

    Unit tests cover 'clib' from within C++ googletest code
- port test-clib to google tests
- rename pre-existing version to test-clib-demo
- add tests indirectly probing SharedCabinet
- add tests for Solution access routines
- add tests for ctonedim
    @ischoegl
    ischoegl committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    f0e7833 View commit details
    Browse the repository at this point in the history

  8. [unittests] Implement gtest for 'test-oneD'

    @ischoegl
    ischoegl committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    2929b0c View commit details
    Browse the repository at this point in the history

  9. [.NET] Add solution to sourcegen configuration

    @ischoegl
    ischoegl committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    dfc6cce View commit details
    Browse the repository at this point in the history

  10. Rename Kinetics::addPhase to Kinetics::addThermo

    @ischoegl
    ischoegl committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    2976be9 View commit details
    Browse the repository at this point in the history

  11. [clib] Add reverse lookup table to SharedCabinet

    @ischoegl
    ischoegl committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    259c6da View commit details
    Browse the repository at this point in the history

  12. [clib] Prevent memory leaks in lookup table 

    As the storage m_table can contain duplicate entries referencing the
same object, all entries need to be stored in the reverse lookup table.
    @ischoegl
    ischoegl committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    c5bf0db View commit details
    Browse the repository at this point in the history

  13. Clarify deprecation warnings

    @ischoegl
    ischoegl committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    07e9210 View commit details
    Browse the repository at this point in the history

  14. [clib] Fix exception handling

    @ischoegl
    ischoegl committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    7935229 View commit details
    Browse the repository at this point in the history

  15. Prevent infinite recursion in Solution callbacks

    @speth
    speth committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    90b19b4 View commit details
    Browse the repository at this point in the history