Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --server --force flag. #973

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

VasilisManol
Copy link
Contributor

@Canop
Copy link
Owner

Canop commented Jan 12, 2025

I have no problem with the feature but what bothers me here is the addition of a launch argument.

Anybody here can comment ? Any alternative to a new argument ? Any idea for making its name more obvious ?

@VasilisManol
Copy link
Contributor Author

I have no problem with the feature but what bothers me here is the addition of a launch argument.

Anybody here can comment ? Any alternative to a new argument ? Any idea for making its name more obvious ?

For my use case, I would actually prefer it to have it by default. I added the flag just for not changing the existing behavior.

@Canop
Copy link
Owner

Canop commented Jan 24, 2025

Given that nobody commented, I suggest you change the PR by removing the additional argument, making it delete the file by default, and we'll see what we do if somebody files an issue for regression.

@VasilisManol VasilisManol force-pushed the add-server-force-flag branch from c40faf3 to 5ac72e7 Compare January 27, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a way to start a server instance with an existing instance name / socket
2 participants