Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bacon-ls documentation #289

Merged
merged 7 commits into from
Jan 3, 2025
Merged

Add bacon-ls documentation #289

merged 7 commits into from
Jan 3, 2025

Conversation

crisidev
Copy link
Contributor

@crisidev crisidev commented Jan 2, 2025

I am not sure about the documentation format, nor if using a new page is a good idea. I am happy to change accordingly to your preferences @Canop :)

@Canop
Copy link
Owner

Canop commented Jan 2, 2025

I think I'll add a "companion tools" menu (same way you have a "Conf" menu here).

This menu will contain your page and another one I'll write for nvim-bacon, and hopefully other ones in the future.

@crisidev
Copy link
Contributor Author

crisidev commented Jan 2, 2025

Sounds good. I can add it as part of this MR if you want.

@Canop
Copy link
Owner

Canop commented Jan 2, 2025

As you like. Either you do the menu or I do it and the nvim-bacon page at the same time.

It's probable I'll have to tune the CSS anyway.

(just in case, adding a menu with mkdocs is easy, see https://github.com/Canop/broot/blob/main/website/mkdocs.yml#L27)

@Canop
Copy link
Owner

Canop commented Jan 3, 2025

Actually, "Community" might become a menu, with items being "bacon dev", "FAQ", "bacon-ls", and "nvim-bacon".

@crisidev
Copy link
Contributor Author

crisidev commented Jan 3, 2025

Actually, "Community" might become a menu, with items being "bacon dev", "FAQ", "bacon-ls", and "nvim-bacon".

I can create the "Communitity" menu, move community.md into FAQ.md for now, add my bacon-ls.md under it. Would this be a good starting point?

@Canop
Copy link
Owner

Canop commented Jan 3, 2025

Do as you feel. I'll take it when you tell me to, and then I'll check and do necessary adjustments.

@crisidev
Copy link
Contributor Author

crisidev commented Jan 3, 2025

I think I am done with my changes. Let me know if you need anything else.

@Canop
Copy link
Owner

Canop commented Jan 3, 2025

There's been 3 commits since you're done. Good thing that I'm at work and can't take it right now 😄

@crisidev
Copy link
Contributor Author

crisidev commented Jan 3, 2025

There's been 3 commits since you're done. Good thing that I'm at work and can't take it right now 😄

Ahahaha, apologies.. I am working on some shiny new features on bacon-ls like code actions and updating things as they happen :)

@crisidev
Copy link
Contributor Author

crisidev commented Jan 3, 2025

I'll publish probably another commit after I am done with my work on code actions. Bear with me :)

@crisidev
Copy link
Contributor Author

crisidev commented Jan 3, 2025

Ok, now I am done for real. I promise..

@Canop
Copy link
Owner

Canop commented Jan 3, 2025

I took it. Now don't do any change. You'll be able to do it after I merged.

@Canop
Copy link
Owner

Canop commented Jan 3, 2025

It's live: https://dystroy.org/bacon/

@Canop Canop merged commit bb80fbe into Canop:main Jan 3, 2025
@crisidev
Copy link
Contributor Author

crisidev commented Jan 3, 2025

Amazing, thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants