Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): introduce PySessionContext and the API for the available function list #858

Merged
merged 7 commits into from
Oct 29, 2024
Merged

feat(core): introduce PySessionContext and the API for the available function list #858

merged 7 commits into from
Oct 29, 2024

Conversation

goldmedal
Copy link
Contributor

@goldmedal goldmedal commented Oct 29, 2024 •
edited
Loading

Description

Introduce the PySessionContext to handle the status of different sessions. The session context contains an analyzed MDL and the required available function list.

Changed

  • Move the transfromed_sql and read_remote_functions to the PySessionContext.
  • Provide the API for the available function list
GET /v3/connector/functions

@github-actions github-actions bot added core ibis dependencies Pull requests that update a dependency file rust Pull requests that update Rust code python Pull requests that update Python code labels Oct 29, 2024
@goldmedal goldmedal marked this pull request as ready for review October 29, 2024 03:17
grieve54706
grieve54706 approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@grieve54706 grieve54706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @goldmedal.

@grieve54706 grieve54706 merged commit 02f6d2f into Canner:main Oct 29, 2024
17 checks passed
@grieve54706 grieve54706 mentioned this pull request Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grieve54706 grieve54706 grieve54706 approved these changes

Assignees
No one assigned
Labels
core dependencies Pull requests that update a dependency file ibis python Pull requests that update Python code rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goldmedal @grieve54706