fix(core): exclude relationship column and calculated field when selecting all in the analysis result #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldmedal
commented
Aug 8, 2024
| assertThat(result.size()).isEqualTo(1); | ||
| assertThat(result.get(0).getSelectItems().size()).isEqualTo(1); | ||
| assertThat(result.get(0).getSelectItems().get(0).getExpression()).isEqualTo("customer_name"); | ||
| assertThat(result.get(0).getSelectItems().get(0).getExprSources()).isEqualTo(List.of(new ExprSource("customer_name", "orders", "customer_name", new NodeLocation(1, 8)))); |
There was a problem hiding this comment.
We won't dig into the expression of a calculated field. So, in the exprSource, we only provide itself.
goldmedal
commented
Aug 8, 2024
| assertThat(result.get(0).getSelectItems().get(0).getExpression()).isEqualTo("customer_name"); | ||
| assertThat(result.get(0).getSelectItems().get(0).getExprSources()).isEqualTo(List.of(new ExprSource("customer_name", "orders", "customer_name", new NodeLocation(1, 8)))); | ||
|
|
||
| statement = parseSql("SELECT customer FROM orders"); |
There was a problem hiding this comment.
A relationship column can't be selected directly. we won't fail the case to make the query stable. However, it's an invalid query for Wren engine.
grieve54706
approved these changes
Aug 12, 2024
|
Hi @goldmedal, does this pr resolve #738? If it is, would you be able to connect the issue? |
Thanks. I have linked the issues. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
close #738
In the normal query, both
relationshipandcalculated fieldwon't be selected when selecting all from a model. We should also exclude them in the analysis result.