Show original characters for string literals instead of escaping #675
Conversation
| assertSqlFormatter("U&'!+10FFFF!6d4B!8Bd5ABC!6d4B!8Bd5' UESCAPE '!'", "'\uDBFF\uDFFF测试ABC测试'"); | ||
| assertSqlFormatter("U&'\\+10FFFF\\6D4B\\8BD5\\0041\\0042\\0043\\6D4B\\8BD5'", "'\uDBFF\uDFFF测试ABC测试'"); | ||
| assertSqlFormatter("U&'\\\\abc\\6D4B'''", "'\\abc测'''"); | ||
| assertSqlFormatter("'攻殻機動隊'", "'攻殻機動隊'"); | ||
| assertSqlFormatter("'😂'", "'😂'"); | ||
| assertSqlFormatter("'시험'", "'시험'"); |
| @@ -33,6 +33,7 @@ | |||
| import static java.util.Objects.requireNonNull; | |||
| import static org.assertj.core.api.Assertions.assertThat; | |||
|
|
|||
| @Test(singleThreaded = true) | |||
There was a problem hiding this comment.
Note: Reloading DuckDB would be triggered by other test cases (set init-sql). Run tests sequentially to avoid testing failure.
There was a problem hiding this comment.
Another test class, TestDuckDBResource, which uses setDuckDBInitSQL, is already set to singleThreaded. They don't affect each other. We don't need to make any adjustments now. If we encounter any issues in the future, we can then modify the test suite as necessary.
| } | ||
|
|
||
| StringBuilder builder = new StringBuilder(); | ||
| if (dialect == DEFAULT || dialect == DUCKDB || dialect == POSTGRES) { |
There was a problem hiding this comment.
I saw there're some DuckDB-specific behaviors. Do they work well if we remove the dialect?
There was a problem hiding this comment.
Don't worry. This condition has a test called testDecimalRewrite to cover it by #261. The test is successful after this adjustment.
Resolve #673
Follow Trino
trinodb/trino#18256