Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion wren/src/wren/mdl/cte_rewriter.py
Original file line number Diff line number Diff line change
Expand Up @@ -226,9 +226,10 @@ def _collect_user_cte_names(ast: exp.Expression) -> set[str]:
for cte in with_clause.expressions:
alias = cte.args.get("alias")
if alias:
names.add(
raw = (
alias.this.name
if isinstance(alias.this, exp.Identifier)
else str(alias.this)
)
names.add(raw.lower())
return names
16 changes: 16 additions & 0 deletions wren/tests/unit/test_cte_rewriter.py
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,22 @@ def test_user_cte_shadows_model(self):
# (wren-core may restructure the query but won't add a model CTE)
assert not _has_cte(result, "orders") or _count_ctes(result) <= 1

def test_user_cte_shadows_model_case_insensitive(self):
"""User CTE 'Orders' (mixed case) should shadow model 'orders'."""
rw = _make_rewriter(_SINGLE_MODEL_MANIFEST, fallback=True)
result = rw.rewrite(
"WITH Orders AS (SELECT 1 AS o_orderkey, 'OPEN' AS o_orderstatus) "
"SELECT * FROM Orders"
)
ast = sqlglot.parse_one(result, dialect="duckdb")
with_clause = ast.args.get("with_")
if with_clause:
cte_names = [
cte.args["alias"].this.name for cte in with_clause.expressions
]
orders_count = sum(1 for n in cte_names if n.lower() == "orders")
assert orders_count <= 1, f"Duplicate 'orders' CTE: {result}"

def test_nested_cte_shadows_model(self):
"""CTE defined in a subquery WITH should also shadow the model name."""
rw = _make_rewriter(_MULTI_MODEL_MANIFEST, fallback=True)
Expand Down
Loading