Skip to content

chore(ibis-server): use LEFT JOIN for table_comments in Trino metadata to avoid missing tables #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
goldmedal merged 1 commit into from
Mar 14, 2026
Merged

chore(ibis-server): use LEFT JOIN for table_comments in Trino metadata to avoid missing tables #1445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ibis-server/app/model/metadata/trino.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def get_table_list(self) -> list[Table]:
ON t.table_catalog = c.table_catalog
AND t.table_schema = c.table_schema
AND t.table_name = c.table_name
INNER JOIN
LEFT JOIN
system.metadata.table_comments AS tc
ON t.table_catalog = tc.catalog_name
AND t.table_schema = tc.schema_name
Expand Down
Loading