Oracle adb integration

ibis-server/Dockerfile

@@ -1,4 +1,4 @@
-FROM python:3.11-buster AS builder
+FROM python:3.11-bookworm AS builder
 
 ARG ENV
 ENV ENV=$ENV
@@ -37,13 +37,13 @@ COPY . .
 RUN just install --without dev
 
 
-FROM python:3.11-slim-buster AS runtime
+FROM python:3.11-slim-bookworm AS runtime
 
 # Add microsoft package list
 RUN apt-get update \
     && apt-get install -y curl gnupg \
-    && curl https://packages.microsoft.com/keys/microsoft.asc | tee /etc/apt/trusted.gpg.d/microsoft.asc \
-    && curl https://packages.microsoft.com/config/debian/11/prod.list | tee /etc/apt/sources.list.d/mssql-release.list \
+    && curl -sSL https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor -o /usr/share/keyrings/microsoft.gpg \
+    && echo "deb [arch=amd64,arm64,armhf signed-by=/usr/share/keyrings/microsoft.gpg] https://packages.microsoft.com/debian/12/prod bookworm main" | tee /etc/apt/sources.list.d/mssql-release.list \
     && apt-get update
 
 # Install msodbcsql 18 driver for mssql
@@ -53,12 +53,22 @@ RUN ACCEPT_EULA=Y apt-get -y install unixodbc-dev msodbcsql18
 RUN apt-get install -y default-libmysqlclient-dev
 
 # libpq-dev is required for psycopg2
-RUN apt-get -y install libpq-dev \
+RUN apt-get -y install libpq-dev
+
+# Install Oracle Instant Client for Oracle database connections
+RUN apt-get install -y wget unzip libaio1 \
+    && wget https://download.oracle.com/otn_software/linux/instantclient/1923000/instantclient-basic-linux.x64-19.23.0.0.0dbru.zip \
+    && unzip instantclient-basic-linux.x64-19.23.0.0.0dbru.zip -d /opt/ \
+    && rm instantclient-basic-linux.x64-19.23.0.0.0dbru.zip \
+    && echo "/opt/instantclient_19_23" > /etc/ld.so.conf.d/oracle-instantclient.conf \
+    && ldconfig \
     && rm -rf /var/lib/apt/lists/*
 
 ENV VIRTUAL_ENV=/app/.venv \
     PATH="/app/.venv/bin:$PATH" \
-    REMOTE_FUNCTION_LIST_PATH=/resources/function_list
+    REMOTE_FUNCTION_LIST_PATH=/resources/function_list \
+    LD_LIBRARY_PATH="/opt/instantclient_19_23:$LD_LIBRARY_PATH" \
+    ORACLE_HOME="/opt/instantclient_19_23"
 
 COPY --from=builder ${VIRTUAL_ENV} ${VIRTUAL_ENV}
 COPY app app

ibis-server/README.md

@@ -81,6 +81,22 @@ OpenTelemetry zero-code instrumentation is highly configurable. You can set the
 
 [Metrics we are tracing right now](./Metrics.md)
 
+## Oracle 19c Compatibility
+
+WrenAI includes a custom Oracle 19c dialect override for generating compatible SQL syntax. See [Oracle 19c Dialect Documentation](docs/oracle_19c_dialect.md) for details.
+
+### Testing Oracle 19c Dialect
+
+Run the Oracle 19c test suite (34 tests):
+```bash
+# Using alias (if configured)
+wren-test-oracle
+
+# Full command
+cd ibis-server
+PYTHONPATH=. poetry run pytest tests/custom_sqlglot/ -m oracle19c -v --confcutdir=tests/custom_sqlglot
+```
+
 ## Contributing
 Please see [CONTRIBUTING.md](docs/CONTRIBUTING.md) for more information.
 

ibis-server/app/custom_sqlglot/dialects/__init__.py

@@ -1,3 +1,4 @@
 # ruff: noqa: F401
 
 from app.custom_sqlglot.dialects.mysql import MySQL
+from app.custom_sqlglot.dialects.oracle import Oracle

ibis-server/app/custom_sqlglot/dialects/oracle.py

@@ -0,0 +1,93 @@
+from loguru import logger
+from sqlglot import exp
+from sqlglot.dialects.oracle import Oracle as OriginalOracle
+
+
+class Oracle(OriginalOracle):
+    """
+    Custom Oracle dialect for Oracle 19c compatibility.
+
+    Overrides SQLGlot's default Oracle dialect to fix specific Oracle 19c issues:
+    - TIMESTAMPTZ → TIMESTAMP type mapping (avoids timezone format issues)
+    - CAST timestamp literals with explicit TO_TIMESTAMP format (fixes ORA-01843)
+    - BOOLEAN → CHAR(1) type mapping (user's boolean representation pattern)
+
+    Note: INTERVAL syntax is fully supported in Oracle 19c and does not need transformation.
+
+    Based on SQLGlot version >=23.4,<26.5
+    """
+
+    class Generator(OriginalOracle.Generator):
+        """Custom generator for Oracle 19c SQL syntax."""
+
+        TYPE_MAPPING = {
+            **OriginalOracle.Generator.TYPE_MAPPING,
+            # Oracle 19c doesn't have native BOOLEAN type (21c+ feature)
+            # Map to CHAR(1) to match our 'Y'/'N' boolean representation pattern
+            exp.DataType.Type.BOOLEAN: "CHAR(1)",
+            # Map TIMESTAMPTZ to TIMESTAMP (without timezone) for Oracle 19c
+            # Avoids format conversion issues with TIMESTAMP WITH TIME ZONE
+            exp.DataType.Type.TIMESTAMPTZ: "TIMESTAMP",
+        }
+
+        TRANSFORMS = {
+            **OriginalOracle.Generator.TRANSFORMS,
+            # Handle CAST to TIMESTAMP with explicit format for string literals (ORA-01843 fix)
+            exp.Cast: lambda self, e: self._handle_cast_oracle19c(e),
+        }
+
+        def __init__(self, *args, **kwargs):
+            """Initialize Oracle 19c generator with logging."""
+            super().__init__(*args, **kwargs)
+            logger.debug("Using custom Oracle 19c dialect for SQL generation")
+
+        def _handle_cast_oracle19c(self, expression: exp.Cast) -> str:
+            """
+            Handle CAST expressions for Oracle 19c timestamp compatibility.
+
+            Oracle 19c cannot implicitly convert string literals like '2025-11-24 00:00:00'
+            when casting to TIMESTAMP. This transform converts:
+
+            CAST('2025-11-24 00:00:00' AS TIMESTAMP)
+            → TO_TIMESTAMP('2025-11-24 00:00:00', 'YYYY-MM-DD HH24:MI:SS')
+
+            Only applies when:
+            - Source is a string literal
+            - Target type is TIMESTAMP or DATE
+            - Literal matches YYYY-MM-DD pattern
+
+            Args:
+                expression: Cast expression node
+
+            Returns:
+                Oracle 19c-compatible SQL string
+            """
+            source = expression.this
+            target_type = expression.to
+
+            # Check if we're casting to TIMESTAMP or DATE
+            if target_type and target_type.this in (exp.DataType.Type.TIMESTAMP, exp.DataType.Type.DATE):
+                # Check if source is a string literal
+                if isinstance(source, exp.Literal) and source.is_string:
+                    literal_value = source.this
+
+                    # Check if it matches YYYY-MM-DD pattern (with or without time)
+                    # Pattern: YYYY-MM-DD or YYYY-MM-DD HH:MI:SS
+                    if literal_value and len(literal_value) >= 10 and literal_value[4] == '-' and literal_value[7] == '-':
+                        # Determine format based on length
+                        if len(literal_value) == 10:
+                            # Just date: YYYY-MM-DD
+                            format_mask = 'YYYY-MM-DD'
+                        elif len(literal_value) == 19:
+                            # Date with time: YYYY-MM-DD HH:MI:SS
+                            format_mask = 'YYYY-MM-DD HH24:MI:SS'
+                        else:
+                            # Other length, use default CAST
+                            return self.cast_sql(expression)
+
+                        # Use TO_TIMESTAMP or TO_DATE with explicit format
+                        func_name = "TO_TIMESTAMP" if target_type.this == exp.DataType.Type.TIMESTAMP else "TO_DATE"
+                        return f"{func_name}('{literal_value}', '{format_mask}')"
+
+            # For all other cases, use default CAST behavior
+            return self.cast_sql(expression)

ibis-server/app/model/__init__.py

@@ -203,19 +203,24 @@ class PostgresConnectionInfo(BaseConnectionInfo):
 
 
 class OracleConnectionInfo(BaseConnectionInfo):
-    host: SecretStr = Field(
-        examples=["localhost"], description="the hostname of your database"
+    host: SecretStr | None = Field(
+        examples=["localhost"], description="the hostname of your database", default=None
     )
-    port: SecretStr = Field(examples=[1521], description="the port of your database")
-    database: SecretStr = Field(
-        examples=["orcl"], description="the database name of your database"
+    port: SecretStr | None = Field(examples=[1521], description="the port of your database", default=None)
+    database: SecretStr | None = Field(
+        examples=["orcl"], description="the database name of your database", default=None
     )
     user: SecretStr = Field(
         examples=["admin"], description="the username of your database"
     )
     password: SecretStr | None = Field(
         examples=["password"], description="the password of your database", default=None
     )
+    dsn: SecretStr | None = Field(
+        examples=["(DESCRIPTION=(ADDRESS=(PROTOCOL=TCP)(HOST=host)(PORT=port))(CONNECT_DATA=(SERVICE_NAME=service)))"],
+        description="Oracle Data Source Name (DSN) - Alternative to host/port/database configuration",
+        default=None
+    )
 
 
 class SnowflakeConnectionInfo(BaseConnectionInfo):
@@ -261,10 +266,10 @@ class TrinoConnectionInfo(BaseConnectionInfo):
 
 class LocalFileConnectionInfo(BaseConnectionInfo):
     url: SecretStr = Field(
-        description="the root path of the local file", default="/", examples=["/data"]
+        description="the root path of the local file", examples=["/data"]
     )
     format: str = Field(
-        description="File format", default="csv", examples=["csv", "parquet", "json"]
+        description="File format", examples=["csv", "parquet", "json"]
     )
 
 

ibis-server/app/model/connector.py

@@ -1,5 +1,6 @@
 import base64
 import importlib
+import logging
 from functools import cache
 from json import loads
 from typing import Any
@@ -17,6 +18,8 @@
 from ibis.backends.sql.compilers.postgres import compiler as postgres_compiler
 from opentelemetry import trace
 
+logger = logging.getLogger(__name__)
+
 from app.model import (
     ConnectionInfo,
     GcsFileConnectionInfo,
@@ -31,6 +34,10 @@
 # Override datatypes of ibis
 importlib.import_module("app.custom_ibis.backends.sql.datatypes")
 
+# Apply Oracle backend patch to fix ORA-00923 error
+from app.model.oracle_backend_patch import patch_oracle_backend
+patch_oracle_backend()
+
 tracer = trace.get_tracer(__name__)
 
 
@@ -70,10 +77,16 @@ def __init__(self, data_source: DataSource, connection_info: ConnectionInfo):
 
     @tracer.start_as_current_span("connector_query", kind=trace.SpanKind.CLIENT)
     def query(self, sql: str, limit: int) -> pd.DataFrame:
+        import sys
+        print(f"🔍 CONNECTOR QUERY: {sql}", file=sys.stderr, flush=True)
+        print(f"🔍 LIMIT: {limit}", file=sys.stderr, flush=True)
+        logger.info(f"🔍 CONNECTOR QUERY: {sql}")
+        logger.info(f"🔍 LIMIT: {limit}")
         return self.connection.sql(sql).limit(limit).to_pandas()
 
     @tracer.start_as_current_span("connector_dry_run", kind=trace.SpanKind.CLIENT)
     def dry_run(self, sql: str) -> None:
+        logger.info(f"🔍 CONNECTOR DRY_RUN: {sql}")
         self.connection.sql(sql)
 
 

ibis-server/app/model/data_source.py

@@ -181,13 +181,24 @@ def get_postgres_connection(info: PostgresConnectionInfo) -> BaseBackend:
 
     @staticmethod
     def get_oracle_connection(info: OracleConnectionInfo) -> BaseBackend:
-        return ibis.oracle.connect(
-            host=info.host.get_secret_value(),
-            port=int(info.port.get_secret_value()),
-            database=info.database.get_secret_value(),
-            user=info.user.get_secret_value(),
-            password=(info.password and info.password.get_secret_value()),
-        )
+        # Build connection parameters
+        connect_params = {
+            "user": info.user.get_secret_value(),
+            "password": (info.password and info.password.get_secret_value()),
+        }
+
+        # If DSN is provided, use it directly
+        if info.dsn:
+            connect_params["dsn"] = info.dsn.get_secret_value()
+        else:
+            # Otherwise use individual host/port/database parameters
+            connect_params.update({
+                "host": info.host.get_secret_value(),
+                "port": int(info.port.get_secret_value()),
+                "database": info.database.get_secret_value(),
+            })
+
+        return ibis.oracle.connect(**connect_params)
 
     @staticmethod
     def get_snowflake_connection(info: SnowflakeConnectionInfo) -> BaseBackend: