chore(ibis): enhance the function list of BigQuery and MSSQL#1336
Merged
douenergy merged 3 commits intoCanner:mainfrom Oct 3, 2025
Merged
chore(ibis): enhance the function list of BigQuery and MSSQL#1336douenergy merged 3 commits intoCanner:mainfrom
douenergy merged 3 commits intoCanner:mainfrom
Conversation
Contributor
WalkthroughUpdated test expectations for BigQuery and MSSQL function-list counts, and added MSSQL-specific handling and imports to the local query runner (validation and connection retrieval, plus transpile dialect set to "tsql"). No public API signatures were changed. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant CLI as query_local_run CLI
participant Runner as query_local_run
participant Validator as MSSqlConnectionInfo
participant Ext as DataSourceExtension
participant Transpiler as Ibis transpile
User->>CLI: run query with data_source="mssql"
CLI->>Runner: dispatch request (data_source="mssql")
Runner->>Validator: MSSqlConnectionInfo.model_validate_json(connection_info)
alt validation OK
Runner->>Ext: get_mssql_connection(connection_info)
Ext-->>Runner: mssql connection
Runner->>Transpiler: transpile(expr, dialect="tsql")
Transpiler-->>Runner: SQL (tsql)
Runner-->>User: execute and return results
else validation fails
Validator-->>Runner: raise validation error
Runner-->>User: surface error
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
date and group_concat function for BigQuery
Contributor
Author
|
BigQuery has been tested locally |
douenergy
approved these changes
Oct 3, 2025
nhaluc1005
pushed a commit
to nhaluc1005/text2sql-practice
that referenced
this pull request
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BigQuery
datefunction: https://cloud.google.com/bigquery/docs/reference/standard-sql/date_functions#dateMSSQL
isnullyearformatgroup_concatSummary by CodeRabbit
New Features
Tests