feat(ibis): add statement_timeout for trino

[goldmedal]

Part of #1267

• Set query_max_execution_time session property for any trino connection by default.

Summary by CodeRabbit

• New Features

  • Added support for Trino-specific query execution timeout handling.
  • Enhanced Trino connector tests with a new timeout scenario using a custom sleep function.

• Bug Fixes

  • Improved error handling to properly detect and report Trino query time limit exceedance as a timeout error.

• Chores

  • Introduced a configuration file to standardize Trino test environment settings.

[coderabbitai]

Walkthrough

This update introduces Trino-specific statement timeout handling in the data source connection logic, adds exception handling for Trino query timeouts, and implements a test to verify Trino query timeout behavior. Additionally, a Trino configuration file is added for testing purposes.

Changes

File(s)	Change Summary
ibis-server/app/model/data_source.py	Added Trino branch in get_connection_info to set session property for query timeout using request headers.
ibis-server/app/util.py	Imported trino and handled TrinoQueryError for timeouts in execute_with_timeout.
ibis-server/tests/resource/trino_etc/config.properties	Added configuration file for Trino test environment setup.
ibis-server/tests/routers/v2/connector/test_trino.py	Added a sleep UDF and a new async test to verify Trino query timeout via statement timeout header.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant API_Server
    participant Trino

    Client->>API_Server: Send query with statement timeout header
    API_Server->>Trino: Forward query with session property for timeout
    Trino-->>API_Server: Responds (timeout error if exceeded)
    API_Server-->>Client: Returns 504 Gateway Timeout if query cancelled

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~15 minutes

Possibly related issues

• Support statement-level timeout for each connection by default #1267: Implements Trino statement timeout handling in DataSource.get_connection_info, directly addressing the issue's requirements.

Suggested labels

ibis, python

Suggested reviewers

• douenergy

Poem

In the warren where queries hop and spin,
Trino now times out, so let tests begin!
A second or three, the rabbit will wait,
But if you take longer, you’ll meet timeout’s fate.
With headers and configs, the code’s now complete—
This patch makes Trino and rabbits compete! 🐇⏳

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 32f195b and a4cc840.

📒 Files selected for processing (4)

• ibis-server/app/model/data_source.py (1 hunks)
• ibis-server/app/util.py (2 hunks)
• ibis-server/tests/resource/trino_etc/config.properties (1 hunks)
• ibis-server/tests/routers/v2/connector/test_trino.py (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (4)

• ibis-server/tests/resource/trino_etc/config.properties
• ibis-server/tests/routers/v2/connector/test_trino.py
• ibis-server/app/model/data_source.py
• ibis-server/app/util.py

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: ci

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.