Skip to content

fix(ibis): remove psycopg2 from the release envrioment#1270

Merged
douenergy merged 1 commit intoCanner:mainfrom
goldmedal:fix/remove-psycopg2-from-prod
Jul 23, 2025
Merged

fix(ibis): remove psycopg2 from the release envrioment#1270
douenergy merged 1 commit intoCanner:mainfrom
goldmedal:fix/remove-psycopg2-from-prod

Conversation

@goldmedal
Copy link
Copy Markdown
Contributor

@goldmedal goldmedal commented Jul 22, 2025

psycopg2 is only used in the dev profile for testing. It shouldn't be imported in the formal release.

Summary by CodeRabbit

  • Refactor
    • Improved exception handling for query timeouts to streamline error management.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jul 22, 2025

Walkthrough

The changes remove the import of the psycopg2 module from a utility file and update exception handling in an asynchronous function to only catch psycopg.errors.QueryCanceled. No modifications were made to function signatures or overall logic.

Changes

File(s) Change Summary
ibis-server/app/util.py Removed psycopg2 import; updated exception handling to only use psycopg.errors.QueryCanceled.

Estimated code review effort

1 (~2 minutes)

Suggested labels

ibis, python

Suggested reviewers

  • douenergy

Poem

A hop and a skip, some imports to prune,
Psycopg2’s gone, not a moment too soon.
Exceptions are tidy, the code’s feeling light,
Bugs kept at bay, everything’s right.
With every small change, our software will bloom—
A rabbit’s delight in a cleaner code room! 🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6f62cd1 and 3897981.

📒 Files selected for processing (1)
  • ibis-server/app/util.py (1 hunks)
🧠 Learnings (1)
ibis-server/app/util.py (3)

Learnt from: goldmedal
PR: #1224
File: ibis-server/app/util.py:50-57
Timestamp: 2025-06-18T02:12:43.570Z
Learning: In the to_json function in ibis-server/app/util.py, the code intentionally uses fetch_df() to get a pandas DataFrame and then calls to_dict(orient='split') because this specific format is required for orjson serialization. The pandas conversion step is necessary to generate the correct dictionary structure for orjson.

Learnt from: goldmedal
PR: #1224
File: ibis-server/app/util.py:49-56
Timestamp: 2025-06-18T02:23:34.040Z
Learning: DuckDB supports querying PyArrow Tables directly in SQL queries without needing to register them. When a pa.Table object is referenced in a FROM clause (e.g., "SELECT ... FROM df" where df is a pa.Table), DuckDB automatically handles the PyArrow object via its "replacement scan" mechanism that recognizes Python variables referencing Arrow objects as SQL tables. No conn.register() call is required.

Learnt from: goldmedal
PR: #1224
File: ibis-server/app/util.py:49-56
Timestamp: 2025-06-18T02:23:34.040Z
Learning: DuckDB supports querying PyArrow Tables directly in SQL queries without needing to register them. When a pa.Table object is referenced in a FROM clause (e.g., "SELECT ... FROM df" where df is a pa.Table), DuckDB automatically handles the PyArrow object without requiring conn.register().

🧰 Additional context used
🧠 Learnings (1)
ibis-server/app/util.py (3)

Learnt from: goldmedal
PR: #1224
File: ibis-server/app/util.py:50-57
Timestamp: 2025-06-18T02:12:43.570Z
Learning: In the to_json function in ibis-server/app/util.py, the code intentionally uses fetch_df() to get a pandas DataFrame and then calls to_dict(orient='split') because this specific format is required for orjson serialization. The pandas conversion step is necessary to generate the correct dictionary structure for orjson.

Learnt from: goldmedal
PR: #1224
File: ibis-server/app/util.py:49-56
Timestamp: 2025-06-18T02:23:34.040Z
Learning: DuckDB supports querying PyArrow Tables directly in SQL queries without needing to register them. When a pa.Table object is referenced in a FROM clause (e.g., "SELECT ... FROM df" where df is a pa.Table), DuckDB automatically handles the PyArrow object via its "replacement scan" mechanism that recognizes Python variables referencing Arrow objects as SQL tables. No conn.register() call is required.

Learnt from: goldmedal
PR: #1224
File: ibis-server/app/util.py:49-56
Timestamp: 2025-06-18T02:23:34.040Z
Learning: DuckDB supports querying PyArrow Tables directly in SQL queries without needing to register them. When a pa.Table object is referenced in a FROM clause (e.g., "SELECT ... FROM df" where df is a pa.Table), DuckDB automatically handles the PyArrow object without requiring conn.register().

🔇 Additional comments (1)
ibis-server/app/util.py (1)

270-271: LGTM! Exception handling correctly updated to match available dependencies.

The exception handling has been properly updated to catch only psycopg.errors.QueryCanceled after removing the psycopg2 import. This change aligns perfectly with the PR objective to remove psycopg2 from the release environment while maintaining proper error handling functionality.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added ibis python Pull requests that update Python code labels Jul 22, 2025
@goldmedal goldmedal requested a review from douenergy July 23, 2025 02:00
@douenergy douenergy merged commit 11b5b5e into Canner:main Jul 23, 2025
5 checks passed
@goldmedal goldmedal deleted the fix/remove-psycopg2-from-prod branch October 14, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ibis python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants