Skip to content

fix(development): upgrade python image to fix nightly image building #1258

Merged
douenergy merged 2 commits intoCanner:mainfrom
goldmedal:fix/upgrade-python-image
Jul 16, 2025
Merged

fix(development): upgrade python image to fix nightly image building #1258
douenergy merged 2 commits intoCanner:mainfrom
goldmedal:fix/upgrade-python-image

Conversation

@goldmedal
Copy link
Copy Markdown
Contributor

@goldmedal goldmedal commented Jul 16, 2025

Description

Summary by CodeRabbit

  • Chores
    • Updated the underlying operating system version used in the server environment to improve compatibility and package support.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jul 16, 2025

Walkthrough

The Dockerfile for ibis-server was updated to use Debian 12 ("bookworm") Python 3.11 images for both builder and runtime stages. The Microsoft package repository setup was changed to use a dearmored GPG keyring file and the repository source was updated to Debian 12 with a signed-by option.

Changes

File(s) Change Summary
ibis-server/Dockerfile Updated base image to Debian 12 for builder and runtime; changed MS GPG key handling and repo source line

Poem

A Docker hop from buster to bookworm,
New base beneath, no cause for alarm.
The ODBC driver finds its way,
On fresher ground it’s here to stay.
With every build the server’s bright,
Bookworm brings the bytes just right! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cf15529 and 5664a15.

📒 Files selected for processing (1)
  • ibis-server/Dockerfile (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • ibis-server/Dockerfile
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: ci

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added ibis python Pull requests that update Python code labels Jul 16, 2025
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🔭 Outside diff range comments (1)
ibis-server/Dockerfile (1)

1-1: Builder & runtime base images diverge – expect ABI mismatch at runtime

The builder stage still uses python:3.11-buster while the runtime stage has moved to python:3.11-slim-bookworm. Native extensions compiled against Buster’s glibc and library versions (e.g., psycopg2, pyarrow, rust-backed wheels) can break when copied into a Bookworm runtime. Align the two stages to the same Debian release.

-FROM python:3.11-buster AS builder
+FROM python:3.11-slim-bookworm AS builder

Re-build locally after this change to ensure all wheels load correctly.

Also applies to: 40-40

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c2b5b94 and cf15529.

📒 Files selected for processing (1)
  • ibis-server/Dockerfile (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: build-ibis-image (linux_arm64_runner, linux/arm64)
  • GitHub Check: build-image
  • GitHub Check: build-ibis-image (ubuntu-latest, linux/amd64)
  • GitHub Check: ci

@goldmedal goldmedal requested a review from douenergy July 16, 2025 03:23
@douenergy douenergy merged commit 34c9bd5 into Canner:main Jul 16, 2025
11 checks passed
@goldmedal goldmedal deleted the fix/upgrade-python-image branch July 16, 2025 03:24
@coderabbitai coderabbitai bot mentioned this pull request Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ibis python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants